ci: Match goreleaser version #1009
Conversation
|
Warning Rate limit exceeded@klauspost has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 43 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe pull request includes updates to the GitHub Actions workflows for Go projects, specifically changing the version of the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
.github/workflows/go.yml (1)
94-97: Summary of goreleaser updatesThe changes in this file update the goreleaser version from v1.20.0 to v2.3.2 and replace the
--rm-distflag with--clean. These updates are consistent with the PR objective to "Match goreleaser version".Consider the following recommendations:
- Update your project's documentation to reflect the new goreleaser version being used.
- Review the goreleaser changelog for any new features or breaking changes that might benefit or affect your project: https://github.com/goreleaser/goreleaser/releases
- If you have any local scripts or documentation referencing goreleaser, make sure to update them to use the new version and flag.
- Consider pinning the goreleaser version in your project's configuration file (if applicable) to ensure consistency across different environments.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/go.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/release.yml (1)
30-30: Approve change, but verify GoReleaser version compatibilityThe change from
--rm-distto--cleanappears to be correct for matching the GoReleaser version. This aligns with the PR objective.Let's verify if this change is consistent with the GoReleaser version being used (2.3.2):
Please review the output of these commands to ensure that the
--cleanflag is the correct usage for GoReleaser version 2.3.2, and that--rm-distis no longer recommended..github/workflows/go.yml (1)
97-97: Approve goreleaser version update and flag change with behavior verification.The goreleaser version has been updated from v1.20.0 to v2.3.2, consistent with the previous change. Additionally, the
--rm-distflag has been replaced with--clean.Please verify that the
--cleanflag behaves the same way as the old--rm-distflag and check if there are any other flag changes that need to be made. You can run the following command to test the snapshot creation with the new flag:Also, check the goreleaser documentation for any other changes in the CLI interface that might affect your workflow:
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
.goreleaser.yml (2)
Line range hint
7-85: LGTM! Consider unifying modfile usage for consistency.The build configurations for "s2c", "s2d", and "s2sx" are well-structured and cover a wide range of platforms and architectures. The use of
-trimpathandCGO_ENABLED=0is commendable for creating reproducible and static binaries.For consistency, consider using a modfile for all builds or removing it from the "s2sx" build. If there's a specific reason for "s2sx" to use a different modfile, it might be helpful to add a comment explaining why.
Line range hint
87-127: LGTM! Consider expanding changelog filters.The configuration for archives, checksums, snapshots, changelogs, and package formats is comprehensive and well-structured. The NFPM configuration is particularly useful for Linux distribution.
Consider expanding the changelog filters to exclude more non-functional changes. For example:
changelog: sort: asc filters: exclude: - '^doc:' - '^docs:' - '^test:' - '^tests:' - '^Update\sREADME.md' - '^ci:' - '^chore:' - '^\s*Merge\s+pull\s+request\s+'This will further refine the changelog to focus on functional changes.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .goreleaser.yml (1 hunks)
Additional comments not posted (2)
.goreleaser.yml (2)
Line range hint
1-127: Summary: GoReleaser configuration successfully updatedThe changes to
.goreleaser.ymlsuccessfully update the configuration to work with the latest version of GoReleaser. Key improvements include:
- Adding version declaration (
version: 2)- Introducing a pre-execution hook (
./gen.sh)- Maintaining comprehensive build configurations for multiple binaries
- Retaining well-structured archive, checksum, snapshot, and package configurations
These updates should streamline the release process and ensure compatibility with the latest GoReleaser features.
To ensure full compatibility, please run the following command to verify the configuration:
#!/bin/bash # Description: Verify the GoReleaser configuration # Test: Check if goreleaser can parse the configuration without errors goreleaser checkThis will validate that the updated configuration is correctly formatted and compatible with the installed GoReleaser version.
1-5: LGTM! Verify thegen.shscript.The addition of the version declaration and pre-execution hook looks good. This update aligns the configuration with GoReleaser's latest format and introduces a preparation step before the release process.
Please ensure that the
gen.shscript exists and has the correct permissions. Run the following script to verify:Verification successful
Verified:
gen.shscript exists and is executable.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and permissions of gen.sh # Test: Check if gen.sh exists and is executable if [ -x "./gen.sh" ]; then echo "gen.sh exists and is executable" else echo "Error: gen.sh is missing or not executable" ls -l ./gen.sh fiLength of output: 314
Script:
#!/bin/bash # Description: Verify the existence and permissions of gen.sh # Test: Check if gen.sh exists and is executable if [ -f "./gen.sh" ]; then if [ -x "./gen.sh" ]; then echo "gen.sh exists and is executable" else echo "Error: gen.sh exists but is not executable" ls -l ./gen.sh fi else echo "Error: gen.sh does not exist" fiLength of output: 116
Summary by CodeRabbit
goreleasertool version in the GitHub Actions workflows to improve performance and compatibility.